Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0a44ab41 authored by Alan Cox's avatar Alan Cox Committed by Greg Kroah-Hartman
Browse files

tty: note race we need to fix 



This was identified by Vincent Pillet with a high speed interface that uses
low latency mode. In the low latency case we have a tiny race but it can
be hit.

Signed-off-by: default avatarAlan Cox <alan@linux.intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fc915c8b

drivers/tty/n_tty.c

+6 −0
Original line number Original line Diff line number Diff line
@@ -1432,6 +1432,12 @@ static void n_tty_receive_buf(struct tty_struct *tty, const unsigned char *cp, 
	 */

	 */

	if (tty->receive_room < TTY_THRESHOLD_THROTTLE)

	if (tty->receive_room < TTY_THRESHOLD_THROTTLE)

		tty_throttle(tty);

		tty_throttle(tty);



        /* FIXME: there is a tiny race here if the receive room check runs

           before the other work executes and empties the buffer (upping

           the receiving room and unthrottling. We then throttle and get

           stuck. This has been observed and traced down by Vincent Pillet/

           We need to address this when we sort out out the rx path locking */

}

}





int is_ignored(int sig)

int is_ignored(int sig)