Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0a018a68 authored by Dan Carpenter's avatar Dan Carpenter Committed by Matthew Garrett
Browse files

wmi: parse_wdg() should return kernel error codes 



The current code returns a mix of acpi_status and kernel error codes.
It should just return kernel error codes.  There are already error paths
in this function which return -ENOMEM and that's what the caller
expects.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMatthew Garrett <matthew.garrett@nebula.com>
parent 5b5c2b3c

drivers/platform/x86/wmi.c

+2 −2
Original line number Diff line number Diff line
@@ -780,7 +780,7 @@ static bool guid_already_parsed(const char *guid_string) 
/*

 * Parse the _WDG method for the GUID data blocks

 */

static acpi_status parse_wdg(acpi_handle handle)

static int parse_wdg(acpi_handle handle)

{

	struct acpi_buffer out = {ACPI_ALLOCATE_BUFFER, NULL};

	union acpi_object *obj;
@@ -812,7 +812,7 @@ static acpi_status parse_wdg(acpi_handle handle) 


		wblock = kzalloc(sizeof(struct wmi_block), GFP_KERNEL);

		if (!wblock)

			return AE_NO_MEMORY;

			return -ENOMEM;



		wblock->handle = handle;

		wblock->gblock = gblock[i];