Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 093d8046 authored by Ken Mills's avatar Ken Mills Committed by Greg Kroah-Hartman
Browse files

n_gsm: gsm_data_alloc buffer allocation could fail and it is not being checked 



gsm_data_alloc buffer allocation could fail and it is not being checked.

Add check for allocated buffer and return if the buffer allocation
fails.

Signed-off-by: default avatarKen Mills <ken.k.mills@intel.com>
Signed-off-by: default avatarAlan Cox <alan@linux.intel.com>
Cc: stable@kernel.org
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent be7a7411

drivers/tty/n_gsm.c

+2 −0
Original line number Original line Diff line number Diff line
@@ -968,6 +968,8 @@ static void gsm_control_reply(struct gsm_mux *gsm, int cmd, u8 *data, 
{

{

	struct gsm_msg *msg;

	struct gsm_msg *msg;

	msg = gsm_data_alloc(gsm, 0, dlen + 2, gsm->ftype);

	msg = gsm_data_alloc(gsm, 0, dlen + 2, gsm->ftype);

	if (msg == NULL)

		return;

	msg->data[0] = (cmd & 0xFE) << 1 | EA;	/* Clear C/R */

	msg->data[0] = (cmd & 0xFE) << 1 | EA;	/* Clear C/R */

	msg->data[1] = (dlen << 1) | EA;

	msg->data[1] = (dlen << 1) | EA;

	memcpy(msg->data + 2, data, dlen);

	memcpy(msg->data + 2, data, dlen);