Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 08ea48a3 authored by Alex Chiang's avatar Alex Chiang Committed by Len Brown
Browse files

ACPI: processor: factor out common _PDC settings 



Both x86 and ia64 initialize _PDC with mostly common bit settings.

Factor out the common settings and leave the arch-specific ones alone.

Cc: Tony Luck <tony.luck@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Signed-off-by: default avatarAlex Chiang <achiang@hp.com>
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent 407cd87c

arch/ia64/kernel/acpi-processor.c

+1 −9
Original line number Diff line number Diff line
@@ -18,15 +18,7 @@ static void init_intel_pdc(struct acpi_processor *pr) 
{

	u32 *buf = (u32 *)pr->pdc->pointer->buffer.pointer;



	buf[0] = ACPI_PDC_REVISION_ID;

	buf[1] = 1;

	buf[2] = ACPI_PDC_EST_CAPABILITY_SMP;

	/*

	 * The default of PDC_SMP_T_SWCOORD bit is set for IA64 cpu so

	 * that OSPM is capable of native ACPI throttling software

	 * coordination using BIOS supplied _TSD info.

	 */

	buf[2] |= ACPI_PDC_SMP_T_SWCOORD;

	buf[2] |= ACPI_PDC_EST_CAPABILITY_SMP;



	return;

}

arch/x86/kernel/acpi/processor.c

+1 −9
Original line number Diff line number Diff line
@@ -16,16 +16,8 @@ static void init_intel_pdc(struct acpi_processor *pr, struct cpuinfo_x86 *c) 
{

	u32 *buf = (u32 *)pr->pdc->pointer->buffer.pointer;



	buf[0] = ACPI_PDC_REVISION_ID;

	buf[1] = 1;

	buf[2] = ACPI_PDC_C_CAPABILITY_SMP;

	buf[2] |= ACPI_PDC_C_CAPABILITY_SMP;



	/*

	 * The default of PDC_SMP_T_SWCOORD bit is set for intel x86 cpu so

	 * that OSPM is capable of native ACPI throttling software

	 * coordination using BIOS supplied _TSD info.

	 */

	buf[2] |= ACPI_PDC_SMP_T_SWCOORD;

	if (cpu_has(c, X86_FEATURE_EST))

		buf[2] |= ACPI_PDC_EST_CAPABILITY_SWSMP;

drivers/acpi/processor_pdc.c

+11 −0
Original line number Diff line number Diff line
@@ -33,6 +33,15 @@ static struct dmi_system_id __cpuinitdata processor_idle_dmi_table[] = { 
	{},

};



static void acpi_set_pdc_bits(u32 *buf)

{

	buf[0] = ACPI_PDC_REVISION_ID;

	buf[1] = 1;



	/* Enable coordination with firmware's _TSD info */

	buf[2] = ACPI_PDC_SMP_T_SWCOORD;

}



static void acpi_processor_init_pdc(struct acpi_processor *pr)

{

	struct acpi_object_list *obj_list;
@@ -63,6 +72,8 @@ static void acpi_processor_init_pdc(struct acpi_processor *pr) 
		return;

	}



	acpi_set_pdc_bits(buf);



	obj->type = ACPI_TYPE_BUFFER;

	obj->buffer.length = 12;

	obj->buffer.pointer = (u8 *) buf;