Commit 0758f4f7 authored Jul 03, 2014 by Stephen M. Cameron Committed by Christoph Hellwig Jul 25, 2014

hpsa: fix bad -ENOMEM return value in hpsa_big_passthru_ioctl



When copy_from_user fails, return -EFAULT, not -ENOMEM

Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Reported-by: Robert Elliott <elliott@hp.com>
Reviewed-by: Joe Handzik <joseph.t.handzik@hp.com>
Reviewed-by: Scott Teel <scott.teel@hp.com>
Reviewed by: Mike MIller <michael.miller@canonical.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>

parent d1fea47c

drivers/scsi/hpsa.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -5093,7 +5093,7 @@ static int hpsa_big_passthru_ioctl(struct ctlr_info h, void __user argp)
		}
		if (ioc->Request.Type.Direction & XFER_WRITE) {
		if (copy_from_user(buff[sg_used], data_ptr, sz)) {
		status = -ENOMEM;
		status = -EFAULT;
		goto cleanup1;
		}
		} else