Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 072d79a3 authored by Changli Gao's avatar Changli Gao Committed by David S. Miller
Browse files

act_nat: fix wild pointer



pskb_may_pull() may change skb pointers, so adjust icmph after pskb_may_pull().

Signed-off-by: default avatarChangli Gao <xiaosuo@gmail.com>
Acked-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6d1d1d39
Loading
Loading
Loading
Loading
+1 −0
Original line number Diff line number Diff line
@@ -218,6 +218,7 @@ static int tcf_nat(struct sk_buff *skb, struct tc_action *a,
		if (!pskb_may_pull(skb, ihl + sizeof(*icmph) + sizeof(*iph)))
			goto drop;

		icmph = (void *)(skb_network_header(skb) + ihl);
		iph = (void *)(icmph + 1);
		if (egress)
			addr = iph->daddr;