Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 06e2e882 authored by Paul Burton's avatar Paul Burton Committed by Ralf Baechle
Browse files

MIPS: mark O32+FP64 experimental for now 



Commit 597ce172 "MIPS: Support for 64-bit FP with O32 binaries"
introduced support for setting Status.FR=1 for O32 binaries with the
EF_MIPS_FP64 ELF header flag set. Whilst this flag is currently
supported by binutils it does introduce an ABI break within userland.
Objects built with EF_MIPS_FP64 cannot be safely linked with those built
without it since code in either object may assume behaviour specific to
a value of FR.

More recently there has been discussion around avoiding further
fragmentation of the O32 ABI whilst still allowing the use of FR=1 and
features such as MSA which depend upon it. Details of the plan to allow
this are still being worked on, and whilst the kernel will need the
ability to handle FR=1 with O32 tasks it is unclear what else it may
need to provide to a userland which seeks to avoid another ABI break. In
order to prevent the proliferation of userland which may rely upon the
current EF_MIPS_FP64 behaviour this patch marks the kernel support for
it experimental & disables it by default. Under current proposals it is
likely that this support can simply be enabled again later, but possibly
after the introduction of further interfaces with userland and support
for the MIPS R5 UFR feature.

Signed-off-by: default avatarPaul Burton <paul.burton@imgtec.com>
Cc: Matthew Fortune <matthew.fortune@imgtec.com>
Cc: linux-mips@linux-mips.org
Cc: Paul Burton <paul.burton@imgtec.com>
Patchwork: https://patchwork.linux-mips.org/patch/6549/


Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
parent a4671094

arch/mips/Kconfig

+9 −3
Original line number Diff line number Diff line
@@ -2353,9 +2353,8 @@ config SECCOMP 
	  If unsure, say Y. Only embedded should say N here.



config MIPS_O32_FP64_SUPPORT

	bool "Support for O32 binaries using 64-bit FP"

	bool "Support for O32 binaries using 64-bit FP (EXPERIMENTAL)"

	depends on 32BIT || MIPS32_O32

	default y

	help

	  When this is enabled, the kernel will support use of 64-bit floating

	  point registers with binaries using the O32 ABI along with the
@@ -2367,7 +2366,14 @@ config MIPS_O32_FP64_SUPPORT 
	  of your kernel & potentially improve FP emulation performance by

	  saying N here.



	  If unsure, say Y.

	  Although binutils currently supports use of this flag the details

	  concerning its effect upon the O32 ABI in userland are still being

	  worked on. In order to avoid userland becoming dependant upon current

	  behaviour before the details have been finalised, this option should

	  be considered experimental and only enabled by those working upon

	  said details.



	  If unsure, say N.



config USE_OF

	bool