Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 066618bc authored by Kishon Vijay Abraham I's avatar Kishon Vijay Abraham I Committed by Felipe Balbi
Browse files

usb: dwc3: core: fix incorrect usage of resource pointer 



Populate the resources for xhci afresh instead of directly using the
*struct resource* of core. *resource* structure has parent, sibling,
child pointers which should be filled only by resource API's. By
directly using the *resource* pointer of core in xhci, these parent,
sibling, child pointers are already populated even before
*platform_device_add* causing side effects.

Cc: stable@vger.kernel.org # v3.4, v3.5
Reported-by: default avatarRuchika Kharwar <ruchika@ti.com>
Tested-by: default avatarMoiz Sonasath <m-sonasath@ti.com>
Signed-off-by: default avatarKishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent 7effdbd6

drivers/usb/dwc3/core.c

+7 −2
Original line number Diff line number Diff line
@@ -436,16 +436,21 @@ static int __devinit dwc3_probe(struct platform_device *pdev) 
		dev_err(dev, "missing IRQ\n");

		return -ENODEV;

	}

	dwc->xhci_resources[1] = *res;

	dwc->xhci_resources[1].start = res->start;

	dwc->xhci_resources[1].end = res->end;

	dwc->xhci_resources[1].flags = res->flags;

	dwc->xhci_resources[1].name = res->name;



	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	if (!res) {

		dev_err(dev, "missing memory resource\n");

		return -ENODEV;

	}

	dwc->xhci_resources[0] = *res;

	dwc->xhci_resources[0].start = res->start;

	dwc->xhci_resources[0].end = dwc->xhci_resources[0].start +

					DWC3_XHCI_REGS_END;

	dwc->xhci_resources[0].flags = res->flags;

	dwc->xhci_resources[0].name = res->name;



	 /*

	  * Request memory region but exclude xHCI regs,