Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 05a5d4d2 authored by Jingoo Han's avatar Jingoo Han Committed by Linus Torvalds
Browse files

backlight: tosa: use devm_gpio_request_one 



By using devm_gpio_request_one it is possible to set the direction and
initial value in one shot.  Thus, using devm_gpio_request_one can make the
code simpler.

Signed-off-by: default avatarJingoo Han <jg1.han@samsung.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: Dmitry Baryshkov <dbaryshkov@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 5a5a0743

drivers/video/backlight/tosa_bl.c

+2 −4
Original line number Diff line number Diff line
@@ -92,14 +92,12 @@ static int tosa_bl_probe(struct i2c_client *client, 


	data->comadj = sharpsl_param.comadj == -1 ? COMADJ_DEFAULT : sharpsl_param.comadj;



	ret = devm_gpio_request(&client->dev, TOSA_GPIO_BL_C20MA, "backlight");

	ret = devm_gpio_request_one(&client->dev, TOSA_GPIO_BL_C20MA,

				GPIOF_OUT_INIT_LOW, "backlight");

	if (ret) {

		dev_dbg(&data->bl->dev, "Unable to request gpio!\n");

		return ret;

	}

	ret = gpio_direction_output(TOSA_GPIO_BL_C20MA, 0);

	if (ret)

		return ret;



	i2c_set_clientdata(client, data);

	data->i2c = client;

drivers/video/backlight/tosa_lcd.c

+2 −6
Original line number Diff line number Diff line
@@ -195,17 +195,13 @@ static int tosa_lcd_probe(struct spi_device *spi) 
	data->spi = spi;

	dev_set_drvdata(&spi->dev, data);



	ret = devm_gpio_request(&spi->dev, TOSA_GPIO_TG_ON, "tg #pwr");

	ret = devm_gpio_request_one(&spi->dev, TOSA_GPIO_TG_ON,

				GPIOF_OUT_INIT_LOW, "tg #pwr");

	if (ret < 0)

		goto err_gpio_tg;



	mdelay(60);



	ret = gpio_direction_output(TOSA_GPIO_TG_ON, 0);

	if (ret < 0)

		goto err_gpio_tg;



	mdelay(60);

	tosa_lcd_tg_init(data);



	tosa_lcd_tg_on(data);