Commit 05644147 authored Feb 09, 2012 by Uwe Kleine-König Committed by Mark Brown Jul 10, 2012

spi/gpio: start with CS non-active



The chip select line was configured as output with the initial value
being active explicitly. It was later deasserted during
spi_bitbang_setup() without any clock activity in between. So it makes
no sense to activate the device at all and the chip select line can
better start non-active.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

parent 619ac8d3

drivers/spi/spi-gpio.c

+2 −1

Original line number	Original line	Diff line number	Diff line
	@@ -235,7 +235,8 @@ static int spi_gpio_setup(struct spi_device *spi)
	status = gpio_request(cs, dev_name(&spi->dev));		status = gpio_request(cs, dev_name(&spi->dev));
	if (status)		if (status)
	return status;		return status;
	status = gpio_direction_output(cs, spi->mode & SPI_CS_HIGH);		status = gpio_direction_output(cs,
			!(spi->mode & SPI_CS_HIGH));
	}		}
	}		}
	if (!status)		if (!status)