Commit 054d8ff3 authored Apr 27, 2006 by Linas Vepstas Committed by Paul Mackerras May 03, 2006

[PATCH] powerpc/pseries: avoid crash in PCI code if mem system not up



The powerpc code is currently performing PCI setup before memory
initialization.  PCI setup touches PCI config space registers.  If the PCI
card is bad, this will evoke an error, which currrently can't be handled,
as the PCI error recovery code expects kmalloc() to be functional.  This
patch will cause the system to punt instead of crashing with

cpu 0x0: Vector: 300 (Data Access) at [c0000000004434d0]
    pc: c0000000000c06b4: .kmem_cache_alloc+0x8c/0xf4
    lr: c00000000004ad6c: .eeh_send_failure_event+0x48/0xfc

This patch will also print name of the offending pci device.

Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>

parent e17df688

arch/powerpc/platforms/pseries/eeh_event.c

+8 −0

Original line number	Diff line number	Diff line
		@@ -118,7 +118,15 @@ int eeh_send_failure_event (struct device_node *dn,
		{
		unsigned long flags;
		struct eeh_event *event;
		char *location;

		if (!mem_init_done) {
		printk(KERN_ERR "EEH: event during early boot not handled\n");
		location = (char *) get_property(dn, "ibm,loc-code", NULL);
		printk(KERN_ERR "EEH: device node = %s\n", dn->full_name);
		printk(KERN_ERR "EEH: PCI location = %s\n", location);
		return 1;
		}
		event = kmalloc(sizeof(*event), GFP_ATOMIC);
		if (event == NULL) {
		printk (KERN_ERR "EEH: out of memory, event not handled\n");