Commit 051bd28e authored May 31, 2016 by Oliver Neukum Committed by Sasha Levin Jul 11, 2016

HID: elo: kill not flush the work



[ Upstream commit ed596a4a88bd161f868ccba078557ee7ede8a6ef ]

Flushing a work that reschedules itself is not a sensible operation. It needs
to be killed. Failure to do so leads to a kernel panic in the timer code.

CC: stable@vger.kernel.org
Signed-off-by: Oliver Neukum <ONeukum@suse.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>

parent 685ed1a6

drivers/hid/hid-elo.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -259,7 +259,7 @@ static void elo_remove(struct hid_device *hdev)
		struct elo_priv *priv = hid_get_drvdata(hdev);

		hid_hw_stop(hdev);
		flush_workqueue(wq);
		cancel_delayed_work_sync(&priv->work);
		kfree(priv);
		}