Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 04d4fbca authored by Mathias Krause's avatar Mathias Krause Committed by David S. Miller
Browse files

l2tp: fix info leak via getsockname() 



The L2TP code for IPv6 fails to initialize the l2tp_unused member of
struct sockaddr_l2tpip6 and that for leaks two bytes kernel stack via
the getsockname() syscall. Initialize l2tp_unused with 0 to avoid the
info leak.

Signed-off-by: default avatarMathias Krause <minipli@googlemail.com>
Cc: James Chapman <jchapman@katalix.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 792039c7

net/l2tp/l2tp_ip6.c

+1 −0
Original line number Diff line number Diff line
@@ -410,6 +410,7 @@ static int l2tp_ip6_getname(struct socket *sock, struct sockaddr *uaddr, 
	lsa->l2tp_family = AF_INET6;

	lsa->l2tp_flowinfo = 0;

	lsa->l2tp_scope_id = 0;

	lsa->l2tp_unused = 0;

	if (peer) {

		if (!lsk->peer_conn_id)

			return -ENOTCONN;