Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 03854518 authored by Vijay kumar Tumati's avatar Vijay kumar Tumati Committed by Gerrit - the friendly Code Review server
Browse files

msm: camera: Update flash msm-camera-node bindings documentation 



Latest dtsi and drivers are not using all the required properties
mentioned in the bindings documentation. So moving some properties
to optional section.

Change-Id: I7420b3295b6f48aaf7da18aa71ec32ed5514eccd
Signed-off-by: default avatarVijay kumar Tumati <vtumati@codeaurora.org>
parent 25cdb235

Documentation/devicetree/bindings/media/video/msm-camera-flash.txt

+18 −18
Original line number Diff line number Diff line
@@ -10,21 +10,6 @@ Required properties: 
    - "qcom,camera-flash"

    - "qcom,led-flash"

    - "qcom,led-flash1"

- reg : offset and length of the register set for the device.

    for the flash operating in compatible mode.

- gpios : should contain phandle to gpio controller node and array of

    #gpio-cells specifying specific gpio (controller specific)

- qcom,gpio-req-tbl-num : should contain index to gpios specific to this flash

- qcom,gpio-req-tbl-flags : should contain direction of gpios present in

    qcom,gpio-req-tbl-num property (in the same order)

- qcom,gpio-req-tbl-label : should contain name of gpios present in

    qcom,gpio-req-tbl-num property (in the same order)

- qcom,gpio-flash-reset : should contain index to gpio used by flash's "flash reset" pin.

- qcom,gpio-flash-en : should contain index to gpio used by flash's "flash enable" pin.

- qcom,gpio-flash-now : should contain index to gpio used by flash's "flash now" pin.

- label : should contain unique flash name to differentiate from other flash

    - "adp1660"

    - "bd7710"

- qcom,flash-type : Should contain type flash device

    - 1 for LED flash

    - 2 for strobe flash
@@ -32,9 +17,6 @@ Required properties: 
      This is a low cost led used for camera flash, the led is driven by

      system power, and use a transistor controlled by external pin to

      gate its on/off state.

- qcom,cci-master : should contain i2c master id to be used for this flash.

    - 0 -> MASTER 0

    - 1 -> MASTER 1

- qcom,flash-source : Should contain array of phandles to flash source nodes.

    - pm8941_flash0 pm8941_flash1
@@ -47,6 +29,24 @@ Optional properties: 
- qcom,max-duration: Max duration in milliseconds the flash can glow.

-qcom,switch-source : Should contain phandle to switch source node.

      This is used to trigger dual led at same time to avoid sync issues.

- qcom,cci-master : should contain i2c master id to be used for this flash.

    - 0 -> MASTER 0

    - 1 -> MASTER 1

- reg : offset and length of the register set for the device.

    for the flash operating in compatible mode.

- gpios : should contain phandle to gpio controller node and array of

    #gpio-cells specifying specific gpio (controller specific)

- qcom,gpio-req-tbl-num : should contain index to gpios specific to this flash

- qcom,gpio-req-tbl-flags : should contain direction of gpios present in

    qcom,gpio-req-tbl-num property (in the same order)

- qcom,gpio-req-tbl-label : should contain name of gpios present in

    qcom,gpio-req-tbl-num property (in the same order)

- qcom,gpio-flash-reset : should contain index to gpio used by flash's "flash reset" pin.

- qcom,gpio-flash-en : should contain index to gpio used by flash's "flash enable" pin.

- qcom,gpio-flash-now : should contain index to gpio used by flash's "flash now" pin.

- label : should contain unique flash name to differentiate from other flash

    - "adp1660"

    - "bd7710"

Example:



qcom,led-flash@60 {