Commit 02d9be1a authored Sep 07, 2012 by Dan Carpenter Committed by Jiri Kosina Sep 08, 2012

HID: picoLCD: fix a NULL test in picolcd_raw_cir()



Smatch complains that the NULL checking in this function is not
consistent and could lead to a NULL dereference.  The comments say that
we should return here if rc_dev is NULL so I've changed the test to
match the comment.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Bruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent eb9001cd

drivers/hid/hid-picolcd_cir.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -51,7 +51,7 @@ int picolcd_raw_cir(struct picolcd_data *data,

		/* ignore if rc_dev is NULL or status is shunned */
		spin_lock_irqsave(&data->lock, flags);
		if (data->rc_dev && (data->status & PICOLCD_CIR_SHUN)) {
		if (!data->rc_dev \|\| (data->status & PICOLCD_CIR_SHUN)) {
		spin_unlock_irqrestore(&data->lock, flags);
		return 1;
		}