Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 02730029 authored by Julia Lawall's avatar Julia Lawall Committed by John W. Linville
Browse files

drivers/net/wireless/libertas_tf: Use kmemdup 

Use kmemdup when some other buffer is immediately copied into the
allocated region.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression from,to,size,flag;
statement S;
@@

-  to = \(kmalloc\|kzalloc\)(size,flag);
+  to = kmemdup(from,size,flag);
   if (to==NULL || ...) S
-  memcpy(to, from, size);
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 80caf601

drivers/net/wireless/libertas_tf/if_usb.c

+2 −3
Original line number Diff line number Diff line
@@ -538,7 +538,8 @@ static void if_usb_receive_fwload(struct urb *urb) 
		return;

	}



	syncfwheader = kmalloc(sizeof(struct fwsyncheader), GFP_ATOMIC);

	syncfwheader = kmemdup(skb->data, sizeof(struct fwsyncheader),

			       GFP_ATOMIC);

	if (!syncfwheader) {

		lbtf_deb_usbd(&cardp->udev->dev, "Failure to allocate syncfwheader\n");

		kfree_skb(skb);
@@ -546,8 +547,6 @@ static void if_usb_receive_fwload(struct urb *urb) 
		return;

	}



	memcpy(syncfwheader, skb->data, sizeof(struct fwsyncheader));



	if (!syncfwheader->cmd) {

		lbtf_deb_usb2(&cardp->udev->dev, "FW received Blk with correct CRC\n");

		lbtf_deb_usb2(&cardp->udev->dev, "FW received Blk seqnum = %d\n",