Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 026dadad authored by Dan Carpenter's avatar Dan Carpenter Committed by Linus Torvalds
Browse files

mwave: fix info leak in mwave_ioctl() 



Smatch complains that on 64 bit systems, there is a hole in the
MW_ABILITIES struct between ->component_count and ->component_list[].
It leaks stack information from the mwave_ioctl() function.

I've added a memset() to initialize the struct to zero.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Cc: Greg KH <greg@kroah.com>
Cc: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 758a6ba3

drivers/char/mwave/tp3780i.c

+1 −0
Original line number Original line Diff line number Diff line
@@ -479,6 +479,7 @@ int tp3780I_QueryAbilities(THINKPAD_BD_DATA * pBDData, MW_ABILITIES * pAbilities 
	PRINTK_2(TRACE_TP3780I,

	PRINTK_2(TRACE_TP3780I,

		"tp3780i::tp3780I_QueryAbilities entry pBDData %p\n", pBDData);

		"tp3780i::tp3780I_QueryAbilities entry pBDData %p\n", pBDData);





	memset(pAbilities, 0, sizeof(*pAbilities));

	/* fill out standard constant fields */

	/* fill out standard constant fields */

	pAbilities->instr_per_sec = pBDData->rDspSettings.uIps;

	pAbilities->instr_per_sec = pBDData->rDspSettings.uIps;

	pAbilities->data_size = pBDData->rDspSettings.uDStoreSize;

	pAbilities->data_size = pBDData->rDspSettings.uDStoreSize;