Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 02512482 authored by Ido Shamay's avatar Ido Shamay Committed by David S. Miller
Browse files

net/mlx4: Set number of RX rings in a utility function 



mlx4_en_add() is too long.
Moving set number of RX rings to a utiltity function to improve
readability and modulization of the code.

Signed-off-by: default avatarIdo Shamay <idos@mellanox.com>
Signed-off-by: default avatarAmir Vadai <amirv@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7a4ddcd9

drivers/net/ethernet/mellanox/mlx4/en_main.c

+2 −13
Original line number Diff line number Diff line
@@ -274,19 +274,8 @@ static void *mlx4_en_add(struct mlx4_dev *dev) 
	if (mdev->dev->caps.flags2 & MLX4_DEV_CAP_FLAG2_TS)

		mlx4_en_init_timestamp(mdev);



	mlx4_foreach_port(i, dev, MLX4_PORT_TYPE_ETH) {

		if (!dev->caps.comp_pool) {

			mdev->profile.prof[i].rx_ring_num =

				rounddown_pow_of_two(max_t(int, MIN_RX_RINGS,

							   min_t(int,

								 dev->caps.num_comp_vectors,

								 DEF_RX_RINGS)));

		} else {

			mdev->profile.prof[i].rx_ring_num = rounddown_pow_of_two(

				min_t(int, dev->caps.comp_pool/

				      dev->caps.num_ports - 1 , MAX_MSIX_P_PORT - 1));

		}

	}

	/* Set default number of RX rings*/

	mlx4_en_set_num_rx_rings(mdev);



	/* Create our own workqueue for reset/multicast tasks

	 * Note: we cannot use the shared workqueue because of deadlocks caused

drivers/net/ethernet/mellanox/mlx4/en_rx.c

+22 −0
Original line number Diff line number Diff line
@@ -318,6 +318,28 @@ static void mlx4_en_free_rx_buf(struct mlx4_en_priv *priv, 
	}

}



void mlx4_en_set_num_rx_rings(struct mlx4_en_dev *mdev)

{

	int i;

	int num_of_eqs;

	struct mlx4_dev *dev = mdev->dev;



	mlx4_foreach_port(i, dev, MLX4_PORT_TYPE_ETH) {

		if (!dev->caps.comp_pool)

			num_of_eqs = max_t(int, MIN_RX_RINGS,

					   min_t(int,

						 dev->caps.num_comp_vectors,

						 DEF_RX_RINGS));

		else

			num_of_eqs = min_t(int, MAX_MSIX_P_PORT,

					   dev->caps.comp_pool/

					   dev->caps.num_ports) - 1;



		mdev->profile.prof[i].rx_ring_num =

			rounddown_pow_of_two(num_of_eqs);

	}

}



int mlx4_en_create_rx_ring(struct mlx4_en_priv *priv,

			   struct mlx4_en_rx_ring **pring,

			   u32 size, u16 stride, int node)

drivers/net/ethernet/mellanox/mlx4/mlx4_en.h

+1 −1
Original line number Diff line number Diff line
@@ -737,7 +737,7 @@ int mlx4_en_activate_tx_ring(struct mlx4_en_priv *priv, 
			     int cq, int user_prio);

void mlx4_en_deactivate_tx_ring(struct mlx4_en_priv *priv,

				struct mlx4_en_tx_ring *ring);



void mlx4_en_set_num_rx_rings(struct mlx4_en_dev *mdev);

int mlx4_en_create_rx_ring(struct mlx4_en_priv *priv,

			   struct mlx4_en_rx_ring **pring,

			   u32 size, u16 stride, int node);