Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 01f10bc8 authored by Ramkumar Ramachandra's avatar Ramkumar Ramachandra Committed by Arnaldo Carvalho de Melo
Browse files

perf diff: Color the Delta column 



Color the numbers in the Delta column using percent_color_snprintf().

Generalize the coloring function so that we can accommodate all three
comparison methods in future patches: delta, ratio, and wdiff.

Signed-off-by: default avatarRamkumar Ramachandra <artagnon@gmail.com>
Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Link: http://lkml.kernel.org/r/1388388861-7931-3-git-send-email-artagnon@gmail.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent f77c6e9c

tools/perf/builtin-diff.c

+48 −1
Original line number Diff line number Diff line
@@ -770,6 +770,45 @@ static int hpp__entry_baseline(struct hist_entry *he, char *buf, size_t size) 
	return ret;

}



static int __hpp__color_compare(struct perf_hpp_fmt *fmt,

				struct perf_hpp *hpp, struct hist_entry *he,

				int comparison_method)

{

	struct diff_hpp_fmt *dfmt =

		container_of(fmt, struct diff_hpp_fmt, fmt);

	struct hist_entry *pair = get_pair_fmt(he, dfmt);

	double diff;

	char pfmt[20] = " ";



	if (!pair)

		goto dummy_print;



	switch (comparison_method) {

	case COMPUTE_DELTA:

		if (pair->diff.computed)

			diff = pair->diff.period_ratio_delta;

		else

			diff = compute_delta(he, pair);



		if (fabs(diff) < 0.01)

			goto dummy_print;

		scnprintf(pfmt, 20, "%%%+d.2f%%%%", dfmt->header_width - 1);

		return percent_color_snprintf(hpp->buf, hpp->size,

					pfmt, diff);

	default:

		BUG_ON(1);

	}

dummy_print:

	return scnprintf(hpp->buf, hpp->size, "%*s",

			dfmt->header_width, pfmt);

}



static int hpp__color_delta(struct perf_hpp_fmt *fmt,

			struct perf_hpp *hpp, struct hist_entry *he)

{

	return __hpp__color_compare(fmt, hpp, he, COMPUTE_DELTA);

}



static void

hpp__entry_unpair(struct hist_entry *he, int idx, char *buf, size_t size)

{
@@ -941,8 +980,16 @@ static void data__hpp_register(struct data__file *d, int idx) 
	fmt->entry  = hpp__entry_global;



	/* TODO more colors */

	if (idx == PERF_HPP_DIFF__BASELINE)

	switch (idx) {

	case PERF_HPP_DIFF__BASELINE:

		fmt->color = hpp__color_baseline;

		break;

	case PERF_HPP_DIFF__DELTA:

		fmt->color = hpp__color_delta;

		break;

	default:

		break;

	}



	init_header(d, dfmt);

	perf_hpp__column_register(fmt);