Commit 01da9f8b authored Dec 09, 2014 by Valdis Kletnieks Committed by Greg Kroah-Hartman Dec 16, 2014

net: fix suspicious rcu_dereference_check in net/sched/sch_fq_codel.c



[ Upstream commit 69204cf7eb9c5a72067ce6922d4699378251d053 ]

commit 46e5da40 (net: qdisc: use rcu prefix and silence
 sparse warnings) triggers a spurious warning:

net/sched/sch_fq_codel.c:97 suspicious rcu_dereference_check() usage!

The code should be using the _bh variant of rcu_dereference.

Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Acked-by: Eric Dumazet <edumazet@google.com>
Acked-by: John Fastabend <john.r.fastabend@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 21ac2deb

net/sched/sch_fq_codel.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -94,7 +94,7 @@ static unsigned int fq_codel_classify(struct sk_buff skb, struct Qdisc sch,
		TC_H_MIN(skb->priority) <= q->flows_cnt)
		return TC_H_MIN(skb->priority);

		filter = rcu_dereference(q->filter_list);
		filter = rcu_dereference_bh(q->filter_list);
		if (!filter)
		return fq_codel_hash(q, skb) + 1;