Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 01a1ac47 authored by Steve Glendinning's avatar Steve Glendinning Committed by David S. Miller
Browse files

smsc95xx: remove unused completion struct 



Oliver Neukum spotted the useless complete() in our async callback.  On
closer inspection, the entire completion struct is unused.  This patch
removes it.

Signed-off-by: default avatarSteve Glendinning <steve.glendinning@smsc.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0db155de

drivers/net/usb/smsc95xx.c

+0 −4
Original line number Diff line number Diff line
@@ -55,7 +55,6 @@ struct smsc95xx_priv { 


struct usb_context {

	struct usb_ctrlrequest req;

	struct completion notify;

	struct usbnet *dev;

};
@@ -316,8 +315,6 @@ static void smsc95xx_async_cmd_callback(struct urb *urb, struct pt_regs *regs) 
	if (status < 0)

		devwarn(dev, "async callback failed with %d", status);



	complete(&usb_context->notify);



	kfree(usb_context);

	usb_free_urb(urb);

}
@@ -348,7 +345,6 @@ static int smsc95xx_write_reg_async(struct usbnet *dev, u16 index, u32 *data) 
	usb_context->req.wValue = 00;

	usb_context->req.wIndex = cpu_to_le16(index);

	usb_context->req.wLength = cpu_to_le16(size);

	init_completion(&usb_context->notify);



	usb_fill_control_urb(urb, dev->udev, usb_sndctrlpipe(dev->udev, 0),

		(void *)&usb_context->req, data, size,