Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 009f85a6 authored by Siddartha Mohanadoss's avatar Siddartha Mohanadoss Committed by Gerrit - the friendly Code Review server
Browse files

mhi_dev: mhi: Fix return type 



Check for non zero value for copy_to_user and copy_from_user
api.

Change-Id: I3d6979700bea8675db983c6e515dac2c4a02b40c
Signed-off-by: default avatarSiddartha Mohanadoss <smohanad@codeaurora.org>
parent 3380d16c

drivers/platform/msm/mhi_dev/mhi_uci.c

+2 −3
Original line number Diff line number Diff line
@@ -202,8 +202,7 @@ static int mhi_uci_send_packet(struct mhi_dev_client **client_handle, void *buf, 
			return -ENOMEM;

		}

		memcpy_result = copy_from_user(data_loc, buf, size);



		if (!memcpy_result)

		if (memcpy_result)

			goto error_memcpy;

	} else {

		data_loc = buf;
@@ -486,7 +485,7 @@ static ssize_t mhi_uci_client_read(struct file *file, char __user *buf, 


	if (uspace_buf_size >= *bytes_pending) {

		addr_offset = uci_handle->pkt_size - *bytes_pending;

		if (!copy_to_user(buf, uci_handle->pkt_loc + addr_offset,

		if (copy_to_user(buf, uci_handle->pkt_loc + addr_offset,

							*bytes_pending)) {

			ret_val = -EIO;

			goto error;