Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 004e45d7 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

[media] tuner-core: handle errors when getting signal strength/afc 



If those callbacks fail, it should return zero, and not a random
value. The previous code assumed that all drivers would only change
signal strength if it succeeds, but this may not be true.

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 6f8ca0b5

drivers/media/v4l2-core/tuner-core.c

+6 −4
Original line number Diff line number Diff line
@@ -220,18 +220,20 @@ static void fe_standby(struct dvb_frontend *fe) 


static int fe_has_signal(struct dvb_frontend *fe)

{

	u16 strength = 0;

	u16 strength;



	fe->ops.tuner_ops.get_rf_strength(fe, &strength);

	if (fe->ops.tuner_ops.get_rf_strength(fe, &strength) < 0)

		return 0;



	return strength;

}



static int fe_get_afc(struct dvb_frontend *fe)

{

	s32 afc = 0;

	s32 afc;



	fe->ops.tuner_ops.get_afc(fe, &afc);

	if (fe->ops.tuner_ops.get_afc(fe, &afc) < 0)

		return 0;



	return afc;

}