Commit fedf266f authored Apr 27, 2017 by Eric Anholt Committed by Wim Van Sebroeck May 19, 2017

watchdog: bcm281xx: Fix use of uninitialized spinlock.



The bcm_kona_wdt_set_resolution_reg() call takes the spinlock, so
initialize it earlier.  Fixes a warning at boot with lock debugging
enabled.

Fixes: 6adb730d ("watchdog: bcm281xx: Watchdog Driver")
Signed-off-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>

parent 07441a7d

drivers/watchdog/bcm_kona_wdt.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -304,6 +304,8 @@ static int bcm_kona_wdt_probe(struct platform_device *pdev)
		if (!wdt)
		return -ENOMEM;

		spin_lock_init(&wdt->lock);

		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
		wdt->base = devm_ioremap_resource(dev, res);
		if (IS_ERR(wdt->base))
		@@ -316,7 +318,6 @@ static int bcm_kona_wdt_probe(struct platform_device *pdev)
		return ret;
		}

		spin_lock_init(&wdt->lock);
		platform_set_drvdata(pdev, wdt);
		watchdog_set_drvdata(&bcm_kona_wdt_wdd, wdt);
		bcm_kona_wdt_wdd.parent = &pdev->dev;