Commit fcd4d35e authored Nov 18, 2014 by Markus Elfring Committed by David S. Miller Nov 19, 2014

netlink: Deletion of an unnecessary check before the function call "__module_get"

The __module_get() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ef87c5d6

net/netlink/af_netlink.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -142,7 +142,6 @@ int netlink_add_tap(struct netlink_tap *nt)
		list_add_rcu(&nt->list, &netlink_tap_all);
		spin_unlock(&netlink_tap_lock);

		if (nt->module)
		__module_get(nt->module);

		return 0;