Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fada24a5 authored by Andreas Kemnade's avatar Andreas Kemnade Committed by Kalle Valo
Browse files

libertas: go back to ps mode without commands pending 



Removes the old todo block and checks only whether ieee powersave
mode is requested. We still have to check for being connected as
this powersave mode includes logic for regularly waking up and
checking for packets which only makes sense when connected.
For not being connected, another mode is needed.

Signed-off-by: default avatarAndreas Kemnade <andreas@kemnade.info>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 57954b94

drivers/net/wireless/marvell/libertas/cmd.c

+5 −31
Original line number Diff line number Diff line
@@ -1428,41 +1428,15 @@ int lbs_execute_next_command(struct lbs_private *priv) 
		 * check if in power save mode, if yes, put the device back

		 * to PS mode

		 */

#ifdef TODO

		/*

		 * This was the old code for libertas+wext. Someone that

		 * understands this beast should re-code it in a sane way.

		 *

		 * I actually don't understand why this is related to WPA

		 * and to connection status, shouldn't powering should be

		 * independ of such things?

		 */

		if ((priv->psmode != LBS802_11POWERMODECAM) &&

		    (priv->psstate == PS_STATE_FULL_POWER) &&

		    ((priv->connect_status == LBS_CONNECTED) ||

		    lbs_mesh_connected(priv))) {

			if (priv->secinfo.WPAenabled ||

			    priv->secinfo.WPA2enabled) {

				/* check for valid WPA group keys */

				if (priv->wpa_mcast_key.len ||

				    priv->wpa_unicast_key.len) {

					lbs_deb_host(

					       "EXEC_NEXT_CMD: WPA enabled and GTK_SET"

					       " go back to PS_SLEEP");

					lbs_set_ps_mode(priv,

							PS_MODE_ACTION_ENTER_PS,

							false);

				}

			} else {

		    (priv->connect_status == LBS_CONNECTED)) {

			lbs_deb_host(

				       "EXEC_NEXT_CMD: cmdpendingq empty, "

				       "go back to PS_SLEEP");

				"EXEC_NEXT_CMD: cmdpendingq empty, go back to PS_SLEEP");

			lbs_set_ps_mode(priv, PS_MODE_ACTION_ENTER_PS,

					false);

		}

	}

#endif

	}



	ret = 0;

done: