Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit faa54be4 authored by Alexei Starovoitov's avatar Alexei Starovoitov Committed by David S. Miller
Browse files

net_sched: act_bpf: remove unnecessary copy 



Fix harmless typo and avoid unnecessary copy of empty 'prog' into
unused 'strcut tcf_bpf_cfg old'.

Fixes: f4eaed28 ("act_bpf: fix memory leaks when replacing bpf programs")
Signed-off-by: default avatarAlexei Starovoitov <ast@plumgrid.com>
Acked-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3c645621

net/sched/act_bpf.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -327,7 +327,7 @@ static int tcf_bpf_init(struct net *net, struct nlattr *nla, 
	prog = to_bpf(act);

	prog = to_bpf(act);

	spin_lock_bh(&prog->tcf_lock);

	spin_lock_bh(&prog->tcf_lock);





	if (ret != ACT_P_CREATED)

	if (res != ACT_P_CREATED)

		tcf_bpf_prog_fill_cfg(prog, &old);

		tcf_bpf_prog_fill_cfg(prog, &old);





	prog->bpf_ops = cfg.bpf_ops;

	prog->bpf_ops = cfg.bpf_ops;