Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fa6256db authored by Dan Carpenter's avatar Dan Carpenter Committed by Linus Walleij
Browse files

gpio: mockup: return -EFAULT if copy_from_user() fails 



copy_from_user() returns the number of bytes remaining to be copied but
we want to return negative error codes on failue.

Fixes: 9202ba23 ("gpio: mockup: implement event injecting over debugfs")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 9ce9f799

drivers/gpio/gpio-mockup.c

+3 −4
Original line number Diff line number Diff line
@@ -197,7 +197,7 @@ static ssize_t gpio_mockup_event_write(struct file *file, 
	struct seq_file *sfile;

	struct gpio_desc *desc;

	struct gpio_chip *gc;

	int status, val;

	int val;

	char buf;



	sfile = file->private_data;
@@ -206,9 +206,8 @@ static ssize_t gpio_mockup_event_write(struct file *file, 
	chip = priv->chip;

	gc = &chip->gc;



	status = copy_from_user(&buf, usr_buf, 1);

	if (status)

		return status;

	if (copy_from_user(&buf, usr_buf, 1))

		return -EFAULT;



	if (buf == '0')

		val = 0;