Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f95367a7 authored by Sean Young's avatar Sean Young Committed by Mauro Carvalho Chehab
Browse files

media: staging: remove lirc_zilog driver 



The ir-kbd-i2c driver behaves like the lirc_zilog driver, except it can
send raw IR and receives scancodes rather than lirccodes.

The lirc_zilog driver only polls if the lirc chardev is opened;
similarly the ir-kbd-i2c driver only polls if the corresponding input
device is opened, or the lirc device.

Polling is disabled during IR transmission through the mutex.

The polling period is 402ms in the ir-kdb-i2c driver, and 260ms in the
lirc_zilog driver.

Signed-off-by: default avatarSean Young <sean@mess.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 1cb26030

drivers/staging/media/Kconfig

+0 −3
Original line number Diff line number Diff line
@@ -31,9 +31,6 @@ source "drivers/staging/media/imx/Kconfig" 


source "drivers/staging/media/omap4iss/Kconfig"



# Keep LIRC at the end, as it has sub-menus

source "drivers/staging/media/lirc/Kconfig"



source "drivers/staging/media/tegra-vde/Kconfig"



endif

drivers/staging/media/Makefile

+0 −1
Original line number Diff line number Diff line
@@ -2,7 +2,6 @@ 
obj-$(CONFIG_I2C_BCM2048)	+= bcm2048/

obj-$(CONFIG_DVB_CXD2099)	+= cxd2099/

obj-$(CONFIG_VIDEO_IMX_MEDIA)	+= imx/

obj-$(CONFIG_LIRC_STAGING)	+= lirc/

obj-$(CONFIG_VIDEO_DM365_VPFE)	+= davinci_vpfe/

obj-$(CONFIG_VIDEO_OMAP4)	+= omap4iss/

obj-$(CONFIG_INTEL_ATOMISP)     += atomisp/

drivers/staging/media/lirc/Kconfig

deleted100644 → 0
+0 −21
Original line number Diff line number Diff line 
#

# LIRC driver(s) configuration

#

menuconfig LIRC_STAGING

	bool "Linux Infrared Remote Control IR receiver/transmitter drivers"

	depends on LIRC

	help

	  Say Y here, and all supported Linux Infrared Remote Control IR and

	  RF receiver and transmitter drivers will be displayed. When paired

	  with a remote control and the lirc daemon, the receiver drivers

	  allow control of your Linux system via remote control.



if LIRC_STAGING



config LIRC_ZILOG

	tristate "Zilog/Hauppauge IR Transmitter"

	depends on LIRC && I2C

	help

	  Driver for the Zilog/Hauppauge IR Transmitter, found on

	  PVR-150/500, HVR-1200/1250/1700/1800, HD-PVR and other cards

endif

drivers/staging/media/lirc/Makefile

deleted100644 → 0
+0 −6
Original line number Diff line number Diff line 
# Makefile for the lirc drivers.

#



# Each configuration option enables a list of files.



obj-$(CONFIG_LIRC_ZILOG)	+= lirc_zilog.o

drivers/staging/media/lirc/TODO

deleted100644 → 0
+0 −36
Original line number Diff line number Diff line 
1. Both ir-kbd-i2c and lirc_zilog provide support for RX events for

the chips supported by lirc_zilog.  Before moving lirc_zilog out of staging:



a. ir-kbd-i2c needs a module parameter added to allow the user to tell

   ir-kbd-i2c to ignore Z8 IR units.



b. lirc_zilog should provide Rx key presses to the rc core like ir-kbd-i2c

   does.





2. lirc_zilog module ref-counting need examination.  It has not been

verified that cdev and lirc_dev will take the proper module references on

lirc_zilog to prevent removal of lirc_zilog when the /dev/lircN device node

is open.



(The good news is ref-counting of lirc_zilog internal structures appears to be

complete.  Testing has shown the cx18 module can be unloaded out from under

irw + lircd + lirc_dev, with the /dev/lirc0 device node open, with no adverse

effects.  The cx18 module could then be reloaded and irw properly began

receiving button presses again and ir_send worked without error.)





3. Bridge drivers, if able, should provide a chip reset() callback

to lirc_zilog via struct IR_i2c_init_data.  cx18 and ivtv already have routines

to perform Z8 chip resets via GPIO manipulations.  This would allow lirc_zilog

to bring the chip back to normal when it hangs, in the same places the

original lirc_pvr150 driver code does.  This is not strictly needed, so it

is not required to move lirc_zilog out of staging.



Note: Both lirc_zilog and ir-kbd-i2c support the Zilog Z8 for IR, as programmed

and installed on Hauppauge products.  When working on either module, developers

must consider at least the following bridge drivers which mention an IR Rx unit

at address 0x71 (indicative of a Z8):



	ivtv cx18 hdpvr pvrusb2 bt8xx cx88 saa7134