Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f666ac0d authored by Jiri Olsa's avatar Jiri Olsa Committed by Arnaldo Carvalho de Melo
Browse files

perf hists: Fix width computation for srcline sort entry 



Adding header size to width computation for srcline sort entry,
because it's possible to get empty data with ':0' which set width
of 2 which is lower than width needed to display column header.

Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Joe Mario <jmario@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1474290610-23241-62-git-send-email-jolsa@kernel.org


[ Added declaration to sort.h ]
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent f82b7746

tools/perf/util/hist.c

+4 −2
Original line number Diff line number Diff line
@@ -177,8 +177,10 @@ void hists__calc_col_len(struct hists *hists, struct hist_entry *h) 
	hists__new_col_len(hists, HISTC_LOCAL_WEIGHT, 12);

	hists__new_col_len(hists, HISTC_GLOBAL_WEIGHT, 12);



	if (h->srcline)

		hists__new_col_len(hists, HISTC_SRCLINE, strlen(h->srcline));

	if (h->srcline) {

		len = MAX(strlen(h->srcline), strlen(sort_srcline.se_header));

		hists__new_col_len(hists, HISTC_SRCLINE, len);

	}



	if (h->srcfile)

		hists__new_col_len(hists, HISTC_SRCFILE, strlen(h->srcfile));

tools/perf/util/sort.h

+1 −0
Original line number Diff line number Diff line
@@ -40,6 +40,7 @@ extern struct sort_entry sort_dso_from; 
extern struct sort_entry sort_dso_to;

extern struct sort_entry sort_sym_from;

extern struct sort_entry sort_sym_to;

extern struct sort_entry sort_srcline;

extern enum sort_type sort__first_dimension;

extern const char default_mem_sort_order[];