Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f3016069 authored by Andrey Smirnov's avatar Andrey Smirnov Committed by Marcel Holtmann
Browse files

at86rf230: Allow slow GPIO pins for "rstn" 



Driver code never touches "rstn" signal in atomic context, so there's
no need to implicitly put such restriction on it by using gpio_set_value
to manipulate it. Replace gpio_set_value to gpio_set_value_cansleep to
fix that.

As a an example of where such restriction might be inconvenient,
consider a hardware design where "rstn" is connected to a pin of I2C/SPI
GPIO expander chip.

Cc: Chris Healy <cphealy@gmail.com>
Signed-off-by: default avatarAndrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: default avatarStefan Schmidt <stefan@osg.samsung.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent 5eb35a6c

drivers/net/ieee802154/at86rf230.c

+2 −2
Original line number Diff line number Diff line
@@ -1715,9 +1715,9 @@ static int at86rf230_probe(struct spi_device *spi) 
	/* Reset */

	if (gpio_is_valid(rstn)) {

		udelay(1);

		gpio_set_value(rstn, 0);

		gpio_set_value_cansleep(rstn, 0);

		udelay(1);

		gpio_set_value(rstn, 1);

		gpio_set_value_cansleep(rstn, 1);

		usleep_range(120, 240);

	}