Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f2899788 authored by Andrew Lunn's avatar Andrew Lunn Committed by David S. Miller
Browse files

net: phy: marvell: Limit errata to 88m1101 



The 88m1101 has an errata when configuring autoneg. However, it was
being applied to many other Marvell PHYs as well. Limit its scope to
just the 88m1101.

Fixes: 76884679 ("phylib: Add support for Marvell 88e1111S and 88e1145")
Reported-by: default avatarDaniel Walker <danielwa@cisco.com>
Signed-off-by: default avatarAndrew Lunn <andrew@lunn.ch>
Acked-by: default avatarHarini Katakam <harinik@xilinx.com>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent cd47512e

drivers/net/phy/marvell.c

+37 −29
Original line number Diff line number Diff line
@@ -255,34 +255,6 @@ static int marvell_config_aneg(struct phy_device *phydev) 
{

	int err;



	/* The Marvell PHY has an errata which requires

	 * that certain registers get written in order

	 * to restart autonegotiation */

	err = phy_write(phydev, MII_BMCR, BMCR_RESET);



	if (err < 0)

		return err;



	err = phy_write(phydev, 0x1d, 0x1f);

	if (err < 0)

		return err;



	err = phy_write(phydev, 0x1e, 0x200c);

	if (err < 0)

		return err;



	err = phy_write(phydev, 0x1d, 0x5);

	if (err < 0)

		return err;



	err = phy_write(phydev, 0x1e, 0);

	if (err < 0)

		return err;



	err = phy_write(phydev, 0x1e, 0x100);

	if (err < 0)

		return err;



	err = marvell_set_polarity(phydev, phydev->mdix_ctrl);

	if (err < 0)

		return err;
@@ -316,6 +288,42 @@ static int marvell_config_aneg(struct phy_device *phydev) 
	return 0;

}



static int m88e1101_config_aneg(struct phy_device *phydev)

{

	int err;



	/* This Marvell PHY has an errata which requires

	 * that certain registers get written in order

	 * to restart autonegotiation

	 */

	err = phy_write(phydev, MII_BMCR, BMCR_RESET);



	if (err < 0)

		return err;



	err = phy_write(phydev, 0x1d, 0x1f);

	if (err < 0)

		return err;



	err = phy_write(phydev, 0x1e, 0x200c);

	if (err < 0)

		return err;



	err = phy_write(phydev, 0x1d, 0x5);

	if (err < 0)

		return err;



	err = phy_write(phydev, 0x1e, 0);

	if (err < 0)

		return err;



	err = phy_write(phydev, 0x1e, 0x100);

	if (err < 0)

		return err;



	return marvell_config_aneg(phydev);

}



static int m88e1111_config_aneg(struct phy_device *phydev)

{

	int err;
@@ -1892,7 +1900,7 @@ static struct phy_driver marvell_drivers[] = { 
		.flags = PHY_HAS_INTERRUPT,

		.probe = marvell_probe,

		.config_init = &marvell_config_init,

		.config_aneg = &marvell_config_aneg,

		.config_aneg = &m88e1101_config_aneg,

		.read_status = &genphy_read_status,

		.ack_interrupt = &marvell_ack_interrupt,

		.config_intr = &marvell_config_intr,