Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e8a732d1 authored by Yossi Kuperman's avatar Yossi Kuperman Committed by David S. Miller
Browse files

udp: fix secpath leak 



After commit dce4551c ("udp: preserve head state for IP_CMSG_PASSSEC")
we preserve the secpath for the whole skb lifecycle, but we also
end up leaking a reference to it.

We must clear the head state on skb reception, if secpath is
present.

Fixes: dce4551c ("udp: preserve head state for IP_CMSG_PASSSEC")
Signed-off-by: default avatarYossi Kuperman <yossiku@mellanox.com>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 79e99bdd

net/ipv4/udp.c

+1 −1
Original line number Diff line number Diff line
@@ -1176,7 +1176,7 @@ static void udp_set_dev_scratch(struct sk_buff *skb) 
	scratch->csum_unnecessary = !!skb_csum_unnecessary(skb);

	scratch->is_linear = !skb_is_nonlinear(skb);

#endif

	if (likely(!skb->_skb_refdst))

	if (likely(!skb->_skb_refdst && !skb_sec_path(skb)))

		scratch->_tsize_state |= UDP_SKB_IS_STATELESS;

}