Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e4ff3d22 authored by Artemy Kovalyov's avatar Artemy Kovalyov Committed by Jason Gunthorpe
Browse files

IB/core: Release object lock if destroy failed 



The object lock was supposed to always be released during destroy, but
when the destruction retry series was integrated with the destroy series
it created a failure path that missed the unlock.

Keep with convention, if destroy fails the caller must undo all locking.

Fixes: 87ad80ab ("IB/uverbs: Consolidate uobject destruction")
Signed-off-by: default avatarArtemy Kovalyov <artemyko@mellanox.com>
Signed-off-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 0d23ba60

drivers/infiniband/core/rdma_core.c

+2 −0
Original line number Diff line number Diff line
@@ -882,6 +882,8 @@ static int __uverbs_cleanup_ufile(struct ib_uverbs_file *ufile, 
		WARN_ON(uverbs_try_lock_object(obj, UVERBS_LOOKUP_WRITE));

		if (!uverbs_destroy_uobject(obj, reason))

			ret = 0;

		else

			atomic_set(&obj->usecnt, 0);

	}

	return ret;

}