Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e3dc17a5 authored by Bjorn Helgaas's avatar Bjorn Helgaas
Browse files

PCI: layerscape: Simplify platform_get_resource_byname() failure checking 



devm_ioremap_resource() validates the resource it receives, so if we check
for devm_ioremap_resource() failure, we need not check for failure of the
preceding platform_get_resource().

Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent c517d838

drivers/pci/host/pci-layerscape.c

+3 −6
Original line number Original line Diff line number Diff line
@@ -127,14 +127,11 @@ static int __init ls_pcie_probe(struct platform_device *pdev) 
	pcie->dev = &pdev->dev;

	pcie->dev = &pdev->dev;





	dbi_base = platform_get_resource_byname(pdev, IORESOURCE_MEM, "regs");

	dbi_base = platform_get_resource_byname(pdev, IORESOURCE_MEM, "regs");

	if (!dbi_base) {

		dev_err(&pdev->dev, "missing *regs* space\n");

		return -ENODEV;

	}



	pcie->dbi = devm_ioremap_resource(&pdev->dev, dbi_base);

	pcie->dbi = devm_ioremap_resource(&pdev->dev, dbi_base);

	if (IS_ERR(pcie->dbi))

	if (IS_ERR(pcie->dbi)) {

		dev_err(&pdev->dev, "missing *regs* space\n");

		return PTR_ERR(pcie->dbi);

		return PTR_ERR(pcie->dbi);

	}





	pcie->scfg = syscon_regmap_lookup_by_phandle(pdev->dev.of_node,

	pcie->scfg = syscon_regmap_lookup_by_phandle(pdev->dev.of_node,

						     "fsl,pcie-scfg");

						     "fsl,pcie-scfg");