Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e32b2c88 authored by Luca Barbieri's avatar Luca Barbieri Committed by Ben Skeggs
Browse files

drm/nouveau: fix missing spin_unlock in failure path 



Found by sparse.

Signed-off-by: default avatarLuca Barbieri <luca@luca-barbieri.com>
Signed-off-by: default avatarFrancisco Jerez <currojerez@riseup.net>
Signed-off-by: default avatarBen Skeggs <bskeggs@redhat.com>
parent 761c5a69

drivers/gpu/drm/nouveau/nouveau_gem.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -558,11 +558,11 @@ nouveau_gem_pushbuf_reloc_apply(struct drm_device *dev, 




		spin_lock(&nvbo->bo.lock);

		spin_lock(&nvbo->bo.lock);

		ret = ttm_bo_wait(&nvbo->bo, false, false, false);

		ret = ttm_bo_wait(&nvbo->bo, false, false, false);

		spin_unlock(&nvbo->bo.lock);

		if (ret) {

		if (ret) {

			NV_ERROR(dev, "reloc wait_idle failed: %d\n", ret);

			NV_ERROR(dev, "reloc wait_idle failed: %d\n", ret);

			break;

			break;

		}

		}

		spin_unlock(&nvbo->bo.lock);





		nouveau_bo_wr32(nvbo, r->reloc_bo_offset >> 2, data);

		nouveau_bo_wr32(nvbo, r->reloc_bo_offset >> 2, data);

	}

	}