Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e28e1d93 authored by Axel Lin's avatar Axel Lin Committed by Dmitry Torokhov
Browse files

Input: rpckbd - fix a leak of the IRQ during init failure 



In rpckbd_open prror path, free_irq() was using NULL rather than the
driver data as the data pointer so free_irq() wouldn't have matched.

Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Signed-off-by: default avatarDmitry Torokhov <dtor@mail.ru>
parent 26fcd2a7

drivers/input/serio/rpckbd.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -90,7 +90,7 @@ static int rpckbd_open(struct serio *port) 




	if (request_irq(IRQ_KEYBOARDTX, rpckbd_tx, 0, "rpckbd", port) != 0) {

	if (request_irq(IRQ_KEYBOARDTX, rpckbd_tx, 0, "rpckbd", port) != 0) {

		printk(KERN_ERR "rpckbd.c: Could not allocate keyboard transmit IRQ\n");

		printk(KERN_ERR "rpckbd.c: Could not allocate keyboard transmit IRQ\n");

		free_irq(IRQ_KEYBOARDRX, NULL);

		free_irq(IRQ_KEYBOARDRX, port);

		return -EBUSY;

		return -EBUSY;

	}

	}