Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e0019f71 authored by Kieran Bingham's avatar Kieran Bingham Committed by Mauro Carvalho Chehab
Browse files

media: i2c: adv748x: Fix cleanup jump on chip identification 



The error handling for the adv748x_identify_chip() call erroneously
jumps to the err_cleanup_clients label before the clients have been
established.

Correct this by jumping to the next (and correct) label in the cleanup
code: err_cleanup_dt.

Fixes: 3e89586a ("media: i2c: adv748x: add adv748x driver")

Signed-off-by: default avatarKieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: default avatarNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 2c737e9c

drivers/media/i2c/adv748x/adv748x-core.c

+1 −1
Original line number Diff line number Diff line
@@ -715,7 +715,7 @@ static int adv748x_probe(struct i2c_client *client, 
	ret = adv748x_identify_chip(state);

	if (ret) {

		adv_err(state, "Failed to identify chip");

		goto err_cleanup_clients;

		goto err_cleanup_dt;

	}



	/* Configure remaining pages as I2C clients with regmap access */