Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit df656bf6 authored by Kees Cook's avatar Kees Cook Committed by David S. Miller
Browse files

qlge: avoid format string exposure in workqueue 



While unlikely, this makes sure the workqueue name won't be processed
as a format string.

Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2f782278

drivers/net/ethernet/qlogic/qlge/qlge_main.c

+2 −1
Original line number Diff line number Diff line
@@ -4686,7 +4686,8 @@ static int ql_init_device(struct pci_dev *pdev, struct net_device *ndev, 
	/*

	 * Set up the operating parameters.

	 */

	qdev->workqueue = alloc_ordered_workqueue(ndev->name, WQ_MEM_RECLAIM);

	qdev->workqueue = alloc_ordered_workqueue("%s", WQ_MEM_RECLAIM,

						  ndev->name);

	INIT_DELAYED_WORK(&qdev->asic_reset_work, ql_asic_reset_work);

	INIT_DELAYED_WORK(&qdev->mpi_reset_work, ql_mpi_reset_work);

	INIT_DELAYED_WORK(&qdev->mpi_work, ql_mpi_work);