Commit dec8e8f6 authored Apr 14, 2016 by Jack Pham Committed by Mark Brown Apr 15, 2016

regmap: spmi: Fix regmap_spmi_ext_read in multi-byte case



Specifically for the case of reads that use the Extended Register
Read Long command, a multi-byte read operation is broken up into
8-byte chunks.  However the call to spmi_ext_register_readl() is
incorrectly passing 'val_size', which if greater than 8 will
always fail.  The argument should instead be 'len'.

Fixes: c9afbb05 ("regmap: spmi: support base and extended register spaces")
Signed-off-by: Jack Pham <jackp@codeaurora.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org

parent f55532a0

drivers/base/regmap/regmap-spmi.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -142,7 +142,7 @@ static int regmap_spmi_ext_read(void *context,
	while (val_size) {		while (val_size) {
	len = min_t(size_t, val_size, 8);		len = min_t(size_t, val_size, 8);

	err = spmi_ext_register_readl(context, addr, val, val_size);		err = spmi_ext_register_readl(context, addr, val, len);
	if (err)		if (err)
	goto err_out;		goto err_out;