Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit db4c5e0b authored by Chris Wilson's avatar Chris Wilson
Browse files

drm/i915: Enable fine-tuned RPS for cherryview



When the RPS tuning was applied to Baytrail, in commit 8fb55197
("drm/i915: Agressive downclocking on Baytrail"), concern was given that
it might cause Cherryview excess wakeups of the common power well.
However, the static thresholds perform poorly for Kodi, and the GPU is
unable to deliver the video frames on time. Enabling the dynamic, finer
thresholds used on all other platforms (including Skylake and Broxton
that also have the same multiple powerwell concerns) allows the GPU to
pick a more appropriate frequency and not drop frames.

Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Link: http://patchwork.freedesktop.org/patch/msgid/20170210150348.22146-1-chris@chris-wilson.co.uk


Reviewed-by: default avatarRadoslaw Szwichtenberg <radoslaw.szwichtenberg@intel.com>
parent 5a4c6f1b
Loading
Loading
Loading
Loading
+1 −2
Original line number Original line Diff line number Diff line
@@ -4971,7 +4971,6 @@ static int valleyview_set_rps(struct drm_i915_private *dev_priv, u8 val)
		if (err)
		if (err)
			return err;
			return err;


		if (!IS_CHERRYVIEW(dev_priv))
		gen6_set_rps_thresholds(dev_priv, val);
		gen6_set_rps_thresholds(dev_priv, val);
	}
	}