Commit d791db9a authored Jun 30, 2017 by Arvind Yadav Committed by Darren Hart (VMware) Jun 30, 2017

platform/x86: sony-laptop: constify attribute_group and input index array



attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group.

The content of sony_laptop_input_index does not change and is declared
as a static global array.

Constify spic_attribute_group and sony_laptop_input_index.

File size before:
   text	   data	    bss	    dec	    hex	filename
  31273	   5176	    372	  36821	   8fd5	drivers/platform/x86/sony-laptop.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
  31337	   5112	    372	  36821	   8fd5	drivers/platform/x86/sony-laptop.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
[dvhart: updated commit message, includes fix suggested by Arnd Bergmann]
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>

parent eee77da1

drivers/platform/x86/sony-laptop.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -222,7 +222,7 @@ struct sony_laptop_keypress {
		/* Correspondance table between sonypi events
		* and input layer indexes in the keymap
		*/
		static int sony_laptop_input_index[] = {
		static const int sony_laptop_input_index[] = {
		-1, /* 0 no event */
		-1, /* 1 SONYPI_EVENT_JOGDIAL_DOWN */
		-1, /* 2 SONYPI_EVENT_JOGDIAL_UP */
		@@ -4032,7 +4032,7 @@ static struct attribute *spic_attributes[] = {
		NULL
		};

		static struct attribute_group spic_attribute_group = {
		static const struct attribute_group spic_attribute_group = {
		.attrs = spic_attributes
		};