Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d6b75584 authored by Andi Kleen's avatar Andi Kleen Committed by H. Peter Anvin
Browse files

x86, mce: disable machine checks on offlined CPUs 



Impact: Lower priority bug fix

Offlined CPUs could still get machine checks, but the machine check handler
cannot handle them properly, leading to an unconditional crash. Disable
machine checks on CPUs that are going down.

Signed-off-by: default avatarAndi Kleen <ak@linux.intel.com>
Acked-by: default avatarThomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarH. Peter Anvin <hpa@zytor.com>
parent 5b4408fd

arch/x86/kernel/cpu/mcheck/mce_64.c

+23 −0
Original line number Diff line number Diff line
@@ -906,6 +906,27 @@ static __cpuinit void mce_remove_device(unsigned int cpu) 
	cpu_clear(cpu, mce_device_initialized);

}



/* Make sure there are no machine checks on offlined CPUs. */

static void __cpuexit mce_disable_cpu(void *h)

{

	int i;



	if (!mce_available(&current_cpu_data))

		return;

	for (i = 0; i < banks; i++)

		wrmsrl(MSR_IA32_MC0_CTL + i*4, 0);

}



static void __cpuexit mce_reenable_cpu(void *h)

{

	int i;



	if (!mce_available(&current_cpu_data))

		return;

	for (i = 0; i < banks; i++)

		wrmsrl(MSR_IA32_MC0_CTL + i*4, bank[i]);

}



/* Get notified when a cpu comes on/off. Be hotplug friendly. */

static int __cpuinit mce_cpu_callback(struct notifier_block *nfb,

				      unsigned long action, void *hcpu)
@@ -929,11 +950,13 @@ static int __cpuinit mce_cpu_callback(struct notifier_block *nfb, 
	case CPU_DOWN_PREPARE:

	case CPU_DOWN_PREPARE_FROZEN:

		del_timer_sync(t);

		smp_call_function_single(cpu, mce_disable_cpu, NULL, 1);

		break;

	case CPU_DOWN_FAILED:

	case CPU_DOWN_FAILED_FROZEN:

		t->expires = round_jiffies_relative(jiffies + next_interval);

		add_timer_on(t, cpu);

		smp_call_function_single(cpu, mce_reenable_cpu, NULL, 1);

		break;

	}

	return NOTIFY_OK;