Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d4fc8bf5 authored by Rajesh Bhagat's avatar Rajesh Bhagat Committed by Greg Kroah-Hartman
Browse files

xhci: fix typo in babble endpoint handling comment 

The 0.95 xHCI spec says that non-control endpoints will be halted if a
babble is detected on a transfer.  The 0.96 xHCI spec says all types of
endpoints will be halted when a babble is detected.  Some hardware that
claims to be 0.95 compliant halts the control endpoint anyway.

Reference: http://www.spinics.net/lists/linux-usb/msg21755.html



Signed-off-by: default avatarRajesh Bhagat <rajesh.bhagat@nxp.com>
Reviewed-by: default avatarFelipe Balbi <balbi@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 351e67ab

drivers/usb/host/xhci-ring.c

+1 −1
Original line number Diff line number Diff line
@@ -1768,7 +1768,7 @@ static int xhci_requires_manual_halt_cleanup(struct xhci_hcd *xhci, 
	if (trb_comp_code == COMP_TX_ERR ||

			trb_comp_code == COMP_BABBLE ||

			trb_comp_code == COMP_SPLIT_ERR)

		/* The 0.96 spec says a babbling control endpoint

		/* The 0.95 spec says a babbling control endpoint

		 * is not halted. The 0.96 spec says it is.  Some HW

		 * claims to be 0.95 compliant, but it halts the control

		 * endpoint anyway.  Check if a babble halted the