Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d2db9a98 authored by Wang Nan's avatar Wang Nan Committed by Arnaldo Carvalho de Melo
Browse files

perf record: Use OPT_BOOLEAN_SET for buildid cache related options 



'perf record' knows whether buildid cache is enabled (via
--no-no-buildid-cache) deliberately. Buildid cache can be turned off in
some situations.

Output switching support needs this feature to turn off buildid cache
by default.

Signed-off-by: default avatarWang Nan <wangnan0@huawei.com>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Brendan Gregg <brendan.d.gregg@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: He Kuang <hekuang@huawei.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Li Zefan <lizefan@huawei.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/1453715801-7732-33-git-send-email-wangnan0@huawei.com


Signed-off-by: default avatarHe Kuang <hekuang@huawei.com>
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 37b20151

tools/perf/builtin-record.c

+8 −4
Original line number Diff line number Diff line
@@ -49,7 +49,9 @@ struct record { 
	const char		*progname;

	int			realtime_prio;

	bool			no_buildid;

	bool			no_buildid_set;

	bool			no_buildid_cache;

	bool			no_buildid_cache_set;

	bool			buildid_all;

	unsigned long long	samples;

};
@@ -1097,9 +1099,11 @@ struct option __record_options[] = { 
	OPT_BOOLEAN('P', "period", &record.opts.period, "Record the sample period"),

	OPT_BOOLEAN('n', "no-samples", &record.opts.no_samples,

		    "don't sample"),

	OPT_BOOLEAN('N', "no-buildid-cache", &record.no_buildid_cache,

	OPT_BOOLEAN_SET('N', "no-buildid-cache", &record.no_buildid_cache,

			&record.no_buildid_cache_set,

			"do not update the buildid cache"),

	OPT_BOOLEAN('B', "no-buildid", &record.no_buildid,

	OPT_BOOLEAN_SET('B', "no-buildid", &record.no_buildid,

			&record.no_buildid_set,

			"do not collect buildids in perf.data"),

	OPT_CALLBACK('G', "cgroup", &record.evlist, "name",

		     "monitor event in cgroup name only",