Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d1f45e60 authored Jan 03, 2015 by Markus Elfring Committed by Takashi Iwai Jan 04, 2015

sound: oss: Deletion of unnecessary checks before the function call "vfree"



The vfree() function performs also input parameter validation. Thus the test
around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 57dca36e

sound/oss/pss.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1228,7 +1228,7 @@ static void __exit cleanup_pss(void)
	{		{
	if(!pss_no_sound)		if(!pss_no_sound)
	{		{
	if(fw_load && pss_synth)		if (fw_load)
	vfree(pss_synth);		vfree(pss_synth);
	if(pssmss)		if(pssmss)
	unload_pss_mss(&cfg2);		unload_pss_mss(&cfg2);

sound/oss/trix.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -487,7 +487,7 @@ static int __init init_trix(void)

	static void __exit cleanup_trix(void)		static void __exit cleanup_trix(void)
	{		{
	if (fw_load && trix_boot)		if (fw_load)
	vfree(trix_boot);		vfree(trix_boot);
	if (sb)		if (sb)
	unload_trix_sb(&cfg2);		unload_trix_sb(&cfg2);