Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d1243806 authored by Dan Carpenter's avatar Dan Carpenter Committed by Takashi Iwai
Browse files

ALSA: opl3: small array underflow 



There is a missing lower bound check on "pitchbend" so it means we can
read up to 6 elements before the start of the opl3_note_table[] array.

Thanks to Clemens Ladisch for his help with this patch.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent f44f07cf

sound/drivers/opl3/opl3_midi.c

+2 −0
Original line number Diff line number Diff line
@@ -105,6 +105,8 @@ static void snd_opl3_calc_pitch(unsigned char *fnum, unsigned char *blocknum, 
		int pitchbend = chan->midi_pitchbend;

		int segment;



		if (pitchbend < -0x2000)

			pitchbend = -0x2000;

		if (pitchbend > 0x1FFF)

			pitchbend = 0x1FFF;