Commit d0280996 authored Dec 20, 2016 by Jeff Mahoney Committed by David Sterba Jan 03, 2017

btrfs: fix locking when we put back a delayed ref that's too new



In __btrfs_run_delayed_refs, when we put back a delayed ref that's too
new, we have already dropped the lock on locked_ref when we set
->processing = 0.

This patch keeps the lock to cover that assignment.

Fixes: d7df2c79 (Btrfs: attach delayed ref updates to delayed ref heads)
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Reviewed-by: Liu Bo <bo.li.liu@oracle.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent aa7c8da3

fs/btrfs/extent-tree.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2522,11 +2522,11 @@ static noinline int __btrfs_run_delayed_refs(struct btrfs_trans_handle *trans,
		if (ref && ref->seq &&
		btrfs_check_delayed_seq(fs_info, delayed_refs, ref->seq)) {
		spin_unlock(&locked_ref->lock);
		btrfs_delayed_ref_unlock(locked_ref);
		spin_lock(&delayed_refs->lock);
		locked_ref->processing = 0;
		delayed_refs->num_heads_ready++;
		spin_unlock(&delayed_refs->lock);
		btrfs_delayed_ref_unlock(locked_ref);
		locked_ref = NULL;
		cond_resched();
		count++;