Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cf8c5009 authored by Viresh Kumar's avatar Viresh Kumar Committed by Daniel Lezcano
Browse files

clockevents/drivers/arm_arch_timer: Implement ->set_state_oneshot_stopped() 



set_state_oneshot_stopped() is called by the clkevt core, when the next
event is required at an expiry time of 'KTIME_MAX'. This normally
happens with NO_HZ_{IDLE|FULL} in both LOWRES/HIGHRES modes.

This patch makes the clockevent device to stop on such an event, to
avoid spurious interrupts, as explained by: commit 8fff52fd
("clockevents: Introduce CLOCK_EVT_STATE_ONESHOT_STOPPED state").

Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
parent bbaa0670

drivers/clocksource/arm_arch_timer.c

+4 −0
Original line number Original line Diff line number Diff line
@@ -274,10 +274,12 @@ static void __arch_timer_setup(unsigned type, 
		if (arch_timer_use_virtual) {

		if (arch_timer_use_virtual) {

			clk->irq = arch_timer_ppi[VIRT_PPI];

			clk->irq = arch_timer_ppi[VIRT_PPI];

			clk->set_state_shutdown = arch_timer_shutdown_virt;

			clk->set_state_shutdown = arch_timer_shutdown_virt;

			clk->set_state_oneshot_stopped = arch_timer_shutdown_virt;

			clk->set_next_event = arch_timer_set_next_event_virt;

			clk->set_next_event = arch_timer_set_next_event_virt;

		} else {

		} else {

			clk->irq = arch_timer_ppi[PHYS_SECURE_PPI];

			clk->irq = arch_timer_ppi[PHYS_SECURE_PPI];

			clk->set_state_shutdown = arch_timer_shutdown_phys;

			clk->set_state_shutdown = arch_timer_shutdown_phys;

			clk->set_state_oneshot_stopped = arch_timer_shutdown_phys;

			clk->set_next_event = arch_timer_set_next_event_phys;

			clk->set_next_event = arch_timer_set_next_event_phys;

		}

		}

	} else {

	} else {
@@ -287,10 +289,12 @@ static void __arch_timer_setup(unsigned type, 
		clk->cpumask = cpu_all_mask;

		clk->cpumask = cpu_all_mask;

		if (arch_timer_mem_use_virtual) {

		if (arch_timer_mem_use_virtual) {

			clk->set_state_shutdown = arch_timer_shutdown_virt_mem;

			clk->set_state_shutdown = arch_timer_shutdown_virt_mem;

			clk->set_state_oneshot_stopped = arch_timer_shutdown_virt_mem;

			clk->set_next_event =

			clk->set_next_event =

				arch_timer_set_next_event_virt_mem;

				arch_timer_set_next_event_virt_mem;

		} else {

		} else {

			clk->set_state_shutdown = arch_timer_shutdown_phys_mem;

			clk->set_state_shutdown = arch_timer_shutdown_phys_mem;

			clk->set_state_oneshot_stopped = arch_timer_shutdown_phys_mem;

			clk->set_next_event =

			clk->set_next_event =

				arch_timer_set_next_event_phys_mem;

				arch_timer_set_next_event_phys_mem;

		}

		}