Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ca0dd273 authored by Daniel Mack's avatar Daniel Mack Committed by Takashi Iwai
Browse files

ALSA: usb: use TEAC UD-H01 quirk for more devices 



The quirk seems to be necessary not only for TEAC UD-H01 devices, but to
more that are based on the Tenor 8802TL chipset. Devices built by T+A
are affected too, and they apparently all use the same USB PID:PID.

Extend the quirky handling for that device as well, and rename the
quirks flag.

Reported-and-tested-by: default avatarThomas Gresens <T.Gresens@intershop.de>
Signed-off-by: default avatarDaniel Mack <daniel@zonque.org>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 9abc1341

sound/usb/card.h

+1 −1
Original line number Diff line number Diff line
@@ -92,7 +92,7 @@ struct snd_usb_endpoint { 
	unsigned int curframesize;      /* current packet size in frames (for capture) */

	unsigned int syncmaxsize;	/* sync endpoint packet size */

	unsigned int fill_max:1;	/* fill max packet size always */

	unsigned int udh01_fb_quirk:1;	/* corrupted feedback data */

	unsigned int tenor_fb_quirk:1;	/* corrupted feedback data */

	unsigned int datainterval;      /* log_2 of data packet interval */

	unsigned int syncinterval;	/* P for adaptive mode, 0 otherwise */

	unsigned char silence_value;

sound/usb/endpoint.c

+3 −2
Original line number Diff line number Diff line
@@ -1167,9 +1167,10 @@ void snd_usb_handle_sync_urb(struct snd_usb_endpoint *ep, 
	if (f == 0)

		return;



	if (unlikely(sender->udh01_fb_quirk)) {

	if (unlikely(sender->tenor_fb_quirk)) {

		/*

		 * The TEAC UD-H01 firmware sometimes changes the feedback value

		 * Devices based on Tenor 8802 chipsets (TEAC UD-H01

		 * and others) sometimes change the feedback value

		 * by +/- 0x1.0000.

		 */

		if (f < ep->freqn - 0x8000)

sound/usb/quirks.c

+3 −2
Original line number Diff line number Diff line
@@ -1218,9 +1218,10 @@ void snd_usb_endpoint_start_quirk(struct snd_usb_endpoint *ep) 
		ep->skip_packets = 16;



	/* Work around devices that report unreasonable feedback data */

	if (ep->chip->usb_id == USB_ID(0x0644, 0x8038) /* TEAC UD-H01 */ &&

	if ((ep->chip->usb_id == USB_ID(0x0644, 0x8038) ||  /* TEAC UD-H01 */

	     ep->chip->usb_id == USB_ID(0x1852, 0x5034)) && /* T+A Dac8 */

	    ep->syncmaxsize == 4)

		ep->udh01_fb_quirk = 1;

		ep->tenor_fb_quirk = 1;

}



void snd_usb_set_interface_quirk(struct usb_device *dev)